Skip to content

PENDING: arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support - #904

Merged
Shiraz Hashim (shashim-quic) merged 6 commits into
qualcomm-linux:staging/nordfrom
drajpura269:pmic_hlos_nord_changes
Aug 26, 2026
Merged

PENDING: arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support#904
Shiraz Hashim (shashim-quic) merged 6 commits into
qualcomm-linux:staging/nordfrom
drajpura269:pmic_hlos_nord_changes

Conversation

@drajpura269

@drajpura269 drajpura269 commented Aug 5, 2026

Copy link
Copy Markdown

PENDING: arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support
Add support for PMM8650AU and KAI_MV PMICs on nord-rrd and nord-ride-sx - new PMICs not present on lemans/monaco, so added new dtsi files (kai_mv-nord.dtsi, pmm8650au-nord.dtsi) with their peripheral definitions (MBG-temp, pon, rtc, gpio), updated nord.dtsi spmi_bus controller node accordingly and added matching compatible strings in the pinctrl-spmi-gpio driver.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch/arm64/boot/dts/qcom/kai_mv-nord.dtsi

sorry what is kai_mv-nord.dtsi ? What h/w module it represent. Please reuse dts/dtsi that represent h/w . On qli we donot refactor dt nodes based on tech area split.

@Komal-Bajaj

Komal Bajaj (Komal-Bajaj) commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

please do write proper commit message
also don't create multiple commits for no reason

@drajpura269

Copy link
Copy Markdown
Author

arch/arm64/boot/dts/qcom/kai_mv-nord.dtsi

sorry what is kai_mv-nord.dtsi ? What h/w module it represent. Please reuse dts/dtsi that represent h/w . On qli we donot refactor dt nodes based on tech area split.

Kai_mv is a new PMIC not present on lemans/monaco, so there was no existing dtsi to reuse - added kai_mv-nord.dtsi
for it. For Kobra (pmm8650au) is a different SIDs then lemans/monaco, so it also needed its own dtsi rather than reusing theirs.

@drajpura269

Copy link
Copy Markdown
Author

please do write proper commit message also don't create multiple commits for no reason

Done - squashed the 7 commits into 2 (pinctrl driver change, DT/dtsi changes) with proper commit messages
describing each change. Pushed the update. Thanks

@drajpura269 drajpura269 changed the title arm64: dts: qcom: iq10: Update SPMI bus and PMIC subnodes arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support Aug 12, 2026
@apateriy-qcom

Copy link
Copy Markdown

for all upstream/already-submitted changes can you please add Link: tag.
(For better trackability)

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from af198eb to 9405b73 Compare August 14, 2026 08:39
@drajpura269

Copy link
Copy Markdown
Author

arch/arm64/boot/dts/qcom/kai_mv-nord.dtsi

sorry what is kai_mv-nord.dtsi ? What h/w module it represent. Please reuse dts/dtsi that represent h/w . On qli we donot refactor dt nodes based on tech area split.

Kai_mv is a new PMIC not present on lemans/monaco, so there was no existing dtsi to reuse - added kai_mv-nord.dtsi for it. For Kobra (pmm8650au) is a different SIDs then lemans/monaco, so it also needed its own dtsi rather than reusing theirs.

I saw that - https://lore.kernel.org/all/177939170556.182385.2422863350479004971.b4-ty@kernel.org/ Here they added kai_mv PMIC so renaming it to pmau0102.

@drajpura269

Copy link
Copy Markdown
Author

for all upstream/already-submitted changes can you please add Link: tag. (For better trackability)

Sure

  1. https://lore.kernel.org/all/177733258718.324244.8879121147375028827.b4-ty@b4/
  2. https://lore.kernel.org/all/177939170556.182385.2422863350479004971.b4-ty@kernel.org/

@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from 9405b73 to fbe3280 Compare August 17, 2026 10:56
@apateriy-qcom

Copy link
Copy Markdown

for all upstream/already-submitted changes can you please add Link: tag. (For better trackability)

Sure

  1. https://lore.kernel.org/all/177733258718.324244.8879121147375028827.b4-ty@b4/
  2. https://lore.kernel.org/all/177939170556.182385.2422863350479004971.b4-ty@kernel.org/

The links should be updated in the commit body. Please take reference from other FROMLIST commits on how to add a lore link.

Comment thread arch/arm64/boot/dts/qcom/nord-ride-sx.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/nord-rrd.dts Outdated

#include "nord-embedded.dtsi"
#include "pmm8650au-nord.dtsi"
#include "pmau0102-nord.dtsi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to before.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Fixed

@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from fbe3280 to 79a469e Compare August 19, 2026 09:07
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@drajpura269

drajpura269 commented Aug 19, 2026

Copy link
Copy Markdown
Author

for all upstream/already-submitted changes can you please add Link: tag. (For better trackability)

Sure

  1. https://lore.kernel.org/all/177733258718.324244.8879121147375028827.b4-ty@b4/
  2. https://lore.kernel.org/all/177939170556.182385.2422863350479004971.b4-ty@kernel.org/

The links should be updated in the commit body. Please take reference from other FROMLIST commits on how to add a lore link.

This changes not on upstream adding "PENDING" tag instead,

@drajpura269
drajpura269 marked this pull request as draft August 19, 2026 09:40
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@drajpura269 drajpura269 changed the title arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support PENDING: arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support Aug 19, 2026
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@shawngsc

Copy link
Copy Markdown

drajpura269 I'm facing an issue on early/hwe/nord-next branch that PMIC interrupt never fires . I wonder whether you tested it good on staging/nord.

@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from 79a469e to b31b954 Compare August 19, 2026 19:40
@shawngsc

Copy link
Copy Markdown

For which PMIC interrupt you are talking about? Can you once check with latest PR?

I'm seeing the issue with PMAU0102 GPIO_08 being interrupt line of FUSB15201 Type-C controller, but I suspect it's an issue with any PMIC interrupts, temp-alarm, pm8xxx_rtc_alarm or pmic_pwrkey. I just tested the latest of this PR with pm8xxx_rtc_alarm. It doesn't tick in /proc/interrupts after an alarm expires like echo +3 > /sys/class/rtc/rtc0/wakealarm.

@drajpura269

Copy link
Copy Markdown
Author

echo +3 > /sys/class/rtc/rtc0/wakealarm

Not sure what's setup difference but I can see the interrupt with the same command you gave.
root@qcom-armv8a:/sys/class/thermal# cat /proc/interrupts | grep rtc
364: 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 pmic_arb 6431274 Edge pm8xxx_rtc_alarm
root@qcom-armv8a:/sys/class/thermal# echo +3 > /sys/class/rtc/rtc0/wakealarm

Comment thread Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Comment thread arch/arm64/boot/dts/qcom/pmm8650au-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmm8650au-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmau0102-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmm8650au-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmau0102-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmau0102-nord.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/pmm8650au-nord.dtsi Outdated
@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from b31b954 to b175ac9 Compare August 21, 2026 07:12
@drajpura269
drajpura269 marked this pull request as ready for review August 21, 2026 08:12
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'staging/nord'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: staging/nord

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Comment thread Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Comment thread Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml
@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch 2 times, most recently from 7111a73 to f5da21f Compare August 25, 2026 12:46
@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from f5da21f to dfb5838 Compare August 26, 2026 05:40
Add the qcom,pmau0102 compatible string to the SPMI PMIC binding for
the new PMIC used on Nord. PMM8650AU (Kobra) reuses the existing
qcom,pmm8654au compatible, as confirmed to be the same PMIC.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
Add the qcom,pmau0102-gpio compatible string to the PMIC GPIO binding
for the new PMIC used on Nord. PMM8650AU (Kobra) reuses the existing
qcom,pmm8654au-gpio compatible, as confirmed to be the same PMIC.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from dfb5838 to e3d2017 Compare August 26, 2026 08:52
Comment thread drivers/pinctrl/qcom/pinctrl-spmi-gpio.c Outdated

@apateriy-qcom apateriy-qcom left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the comment.

Add the qcom,pmau0102-gpio SPMI GPIO compatible string, with 12
GPIOs, for the new PMIC used on Nord. PMM8650AU (Kobra) reuses the
existing qcom,pmm8654au-gpio compatible, as confirmed to be the same
PMIC, so the driver already binds against it.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
Add a qcom,pmau0102-mbg-tm compatible with qcom,pm8775-mbg-tm as
fallback, so the MBG temperature monitor on PMAU0102 can be
distinguished from the existing PM8775 MBG hardware while still
binding against the same driver.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
PMAU0102 and PMM8650AU are new PMICs used on nord-rrd and
nord-ride-sx that are not present on lemans/monaco, so there is no
existing dtsi to reuse. Add per-chip PMIC dtsi files (pmau0102-nord.dtsi,
pmm8650au-nord.dtsi) with their peripheral definitions, matching the
hardware-per-file convention used for other PMICs. Update the
spmi_bus controller node in nord.dtsi accordingly and include the new
per-chip dtsi files from nord-embedded.dtsi, shared by both
nord-rrd.dts and nord-ride-sx.dts.

PMAU0102 instances (pmau0102_e through pmau0102_l) get gpio, adc and
an MBG(Master Bandgap) temperature monitor wired to a DIE_TEMP ADC
channel, using the qcom,pmau0102-mbg-tm compatible with
qcom,pm8775-mbg-tm as fallback.

PMM8650AU (Kobra) is confirmed to be the same PMIC as PMM8654AU, so
its instances reuse the existing qcom,pmm8654au and
qcom,pmm8654au-gpio compatibles. The Kobra_MM instance (kobra_mm_a)
gets pon, rtc, gpio and adc; apps does not have permission for its
qcom,spmi-temp-alarm peripheral, so no thermal sensor is added for
it. The Kobra_PSAIL instance (kobra_psail_b) gets an MBG temperature
monitor wired to kobra_mm_a's DIE_TEMP ADC channel, since Kobra_PSAIL
has no ADC of its own.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
Enable qcom,spmi-adc5-gen3 and qcom,pm8775-mbg-tm so the PMAU0102 and
PMM8650AU MBG temperature sensors and their backing ADC channels are
built into the Nord kernel image.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
@drajpura269
drajpura269 force-pushed the pmic_hlos_nord_changes branch from e3d2017 to d31f804 Compare August 26, 2026 09:19
@drajpura269

Copy link
Copy Markdown
Author

please resolve the comment.

Resolved

@shashim-quic
Shiraz Hashim (shashim-quic) merged commit 9e2ab33 into qualcomm-linux:staging/nord Aug 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants